-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#134 new sprintf function allowing multiple key/value replacement #138
base: master
Are you sure you want to change the base?
Conversation
|
||
|
||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I'll accept this function
end sprintf; | ||
|
||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since all the code is in one PR I'll accept this but remove this function. It's already handled in standard sprintf
@Nunalves I appreciate you submitting the code. I don't think we'll be implementing this for a few reasons:
Let me know if you're ok with these reasons or if I'm missing something. |
@martindsouza i appreciate you getting back to me to check my opinion on this. |
@Nunalves all very good points and I hadn't considered the concatenation issue. Any idea on how to get around the schema level type option? This is one of my biggest concerns as I'd like to avoid any restrictions from developers using this. One idea I have is what if we overload
This would work well when calling from PL/SQL ex:
The only negative thing is that you can't call it from SQL as it's not a recognized type. Let me know what you think. |
#134